lkml.org 
[lkml]   [2018]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] nvmem: lpc18xx_otp: fix ptr_ret.cocci warnings
From: Fengguang Wu <fengguang.wu@intel.com>

drivers/nvmem/lpc18xx_otp.c:90:1-3: WARNING: PTR_ERR_OR_ZERO can be used


Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: e738282235ec ("nvmem: lpc18xx_otp: Convert to use devm_nvmem_register()")
CC: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

lpc18xx_otp.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/nvmem/lpc18xx_otp.c
+++ b/drivers/nvmem/lpc18xx_otp.c
@@ -87,10 +87,7 @@ static int lpc18xx_otp_probe(struct plat
lpc18xx_otp_nvmem_config.priv = otp;

nvmem = devm_nvmem_register(&pdev->dev, &lpc18xx_otp_nvmem_config);
- if (IS_ERR(nvmem))
- return PTR_ERR(nvmem);
-
- return 0;
+ return PTR_ERR_OR_ZERO(nvmem);
}

static const struct of_device_id lpc18xx_otp_dt_ids[] = {
\
 
 \ /
  Last update: 2018-03-04 14:05    [W:0.166 / U:0.548 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site