lkml.org 
[lkml]   [2018]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 16/16] mmc: tmio: remove useless TMIO_MASK_CMD handling in tmio_mmc_host_probe()
On Thu, Jan 18, 2018 at 01:28:16AM +0900, Masahiro Yamada wrote:
> TMIO_MASK_CMD is properly enabled in tmio_mmc_start_command().
>
> We have no reason to set it up in tmio_mmc_host_probe(). (If we
> really wanted to set it in the probe, we would have to do likewise
> when resuming.)
>
> Even worse, the following code is extremely confusing:
>
> _host->sdcard_irq_mask &= ~irq_mask;
>
> The logic is opposite between "->sdcard_irq_mask" and "irq_mask".
> The intention is not clear at a glance.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-03-04 23:40    [W:0.329 / U:1.592 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site