lkml.org 
[lkml]   [2018]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC V2 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events
On Sun, Mar 04, 2018 at 09:12:45AM -0800, Andi Kleen wrote:
> > > +#include <fnmatch.h>
> > > #include <linux/compiler.h>
> > > #include <linux/list.h>
> > > #include <linux/types.h>
> > > @@ -241,7 +242,7 @@ PE_NAME opt_event_config
> > > if (!strncmp(name, "uncore_", 7) &&
> > > strncmp($1, "uncore_", 7))
> > > name += 7;
> > > - if (!strncmp($1, name, strlen($1))) {
> > > + if (!strncmp($1, name, strlen($1)) || !fnmatch($1, name, 0)) {
> >
> > could we now get rid of the strncmp in here and keep the
> > glob matching only?
>
> That would break existing command lines. Not a good idea.

I hoped that only you guys are using this and would rewrite your scripts ;-)

I had no idea there's fnmatch func before.. too bad, ok

jirka

\
 
 \ /
  Last update: 2018-03-04 19:11    [W:0.066 / U:0.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site