Messages in this thread | | | Date | Sun, 4 Mar 2018 09:12:45 -0800 | From | Andi Kleen <> | Subject | Re: [RFC V2 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events |
| |
> > +#include <fnmatch.h> > > #include <linux/compiler.h> > > #include <linux/list.h> > > #include <linux/types.h> > > @@ -241,7 +242,7 @@ PE_NAME opt_event_config > > if (!strncmp(name, "uncore_", 7) && > > strncmp($1, "uncore_", 7)) > > name += 7; > > - if (!strncmp($1, name, strlen($1))) { > > + if (!strncmp($1, name, strlen($1)) || !fnmatch($1, name, 0)) { > > could we now get rid of the strncmp in here and keep the > glob matching only?
That would break existing command lines. Not a good idea.
-Andi
| |