lkml.org 
[lkml]   [2018]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.14 17/84] crypto: cavium - fix memory leak on info
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 87aae50af730a28dc1d8846d86dca5e9aa724a9f ]

    The object info is being leaked on an error return path, fix this
    by setting ret to -ENOMEM and exiting via the request_cleanup path
    that will free info.

    Detected by CoverityScan, CID#1408439 ("Resource Leak")

    Fixes: c694b233295b ("crypto: cavium - Add the Virtual Function driver for CPT")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
    index 169e66231bcf..b0ba4331944b 100644
    --- a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
    +++ b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
    @@ -459,7 +459,8 @@ int process_request(struct cpt_vf *cptvf, struct cpt_request_info *req)
    info->completion_addr = kzalloc(sizeof(union cpt_res_s), GFP_KERNEL);
    if (unlikely(!info->completion_addr)) {
    dev_err(&pdev->dev, "Unable to allocate memory for completion_addr\n");
    - return -ENOMEM;
    + ret = -ENOMEM;
    + goto request_cleanup;
    }

    result = (union cpt_res_s *)info->completion_addr;
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-04 01:27    [W:4.036 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site