lkml.org 
[lkml]   [2018]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 146/219] usb: dwc2: Make sure we disconnect the gadget state
    Date
    From: John Stultz <john.stultz@linaro.org>

    [ Upstream commit dad3f793f20fbb5c0c342f0f5a0bdf69a4d76089 ]

    I had seen some odd behavior with HiKey's usb-gadget interface
    that I finally seemed to have chased down. Basically every other
    time I plugged in the OTG port, the gadget interface would
    properly initialize. The other times, I'd get a big WARN_ON
    in dwc2_hsotg_init_fifo() about the fifo_map not being clear.

    Ends up if we don't disconnect the gadget state, the fifo-map
    doesn't get cleared properly, which causes WARN_ON messages and
    also results in the device not properly being setup as a gadget
    every other time the OTG port is connected.

    So this patch adds a call to dwc2_hsotg_disconnect() in the
    reset path so the state is properly cleared.

    With it, the gadget interface initializes properly on every
    plug in.

    Cc: Wei Xu <xuwei5@hisilicon.com>
    Cc: Guodong Xu <guodong.xu@linaro.org>
    Cc: Amit Pundir <amit.pundir@linaro.org>
    Cc: Rob Herring <robh+dt@kernel.org>
    Cc: John Youn <johnyoun@synopsys.com>
    Cc: Douglas Anderson <dianders@chromium.org>
    Cc: Chen Yu <chenyu56@huawei.com>
    Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: linux-usb@vger.kernel.org
    Acked-by: John Youn <johnyoun@synopsys.com>
    Signed-off-by: John Stultz <john.stultz@linaro.org>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/usb/dwc2/hcd.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
    index df5a06578005..dfc0566bb155 100644
    --- a/drivers/usb/dwc2/hcd.c
    +++ b/drivers/usb/dwc2/hcd.c
    @@ -3220,6 +3220,7 @@ static void dwc2_conn_id_status_change(struct work_struct *work)
    dwc2_core_init(hsotg, false);
    dwc2_enable_global_interrupts(hsotg);
    spin_lock_irqsave(&hsotg->lock, flags);
    + dwc2_hsotg_disconnect(hsotg);
    dwc2_hsotg_core_init_disconnected(hsotg, false);
    spin_unlock_irqrestore(&hsotg->lock, flags);
    dwc2_hsotg_core_connect(hsotg);
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-04 00:38    [W:4.054 / U:0.984 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site