Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 3 Mar 2018 18:04:38 +0200 | Subject | Re: [PATCH v2] 8250-men-mcb: add support for 16z025 and 16z057 |
| |
On Sat, Mar 3, 2018 at 6:51 AM, kbuild test robot <lkp@intel.com> wrote: > Hi Michael, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on tty/tty-testing] > [also build test ERROR on v4.16-rc3 next-20180302] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Michael-Moese/8250-men-mcb-add-support-for-16z025-and-16z057/20180303-104548 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing > config: sparc64-allyesconfig (attached as .config) > compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=sparc64 > > All errors (new ones prefixed by >>): > > drivers/tty/serial/8250/8250_men_mcb.c: In function 'get_num_ports': >>> drivers/tty/serial/8250/8250_men_mcb.c:59:10: error: implicit declaration of function 'readb' [-Werror=implicit-function-declaration] > return readb(membase) >> 4; > ^~~~~ > cc1: some warnings being treated as errors
I suppose kbuildbot can generate patches in similar cases, i.e. adding "#include <linux/io.h>" has to cure this.
> > vim +/readb +59 drivers/tty/serial/8250/8250_men_mcb.c > > 51 > 52 static unsigned int get_num_ports(struct mcb_device *mdev, > 53 void __iomem *membase) > 54 { > 55 switch (mdev->id) { > 56 case MEN_UART_ID_Z125: > 57 return 1U; > 58 case MEN_UART_ID_Z025: > > 59 return readb(membase) >> 4; > 60 case MEN_UART_ID_Z057: > 61 return 4U; > 62 default: > 63 dev_err(&mdev->dev, "no supported device!\n"); > 64 return -ENODEV; > 65 } > 66 } > 67 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation
-- With Best Regards, Andy Shevchenko
| |