Messages in this thread | | | Date | Thu, 29 Mar 2018 13:56:30 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function |
| |
On Thu, Mar 29, 2018 at 01:21:14PM +0200, Hans de Goede wrote: > +void vbg_req_free(void *req, size_t len) > +{ > + if (!req) > + return; > + > + kfree(req); > +}
Wait, no, this isn't ok. Don't create wrapper functions that you never use except as a wrapper :(
I can see someone sending me almost the indental revert patch right after this one gets applied...
thanks,
greg k-h
| |