lkml.org 
[lkml]   [2018]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function
On Thu, Mar 29, 2018 at 01:21:14PM +0200, Hans de Goede wrote:
> +void vbg_req_free(void *req, size_t len)
> +{
> + if (!req)
> + return;
> +
> + kfree(req);
> +}

Wait, no, this isn't ok. Don't create wrapper functions that you never
use except as a wrapper :(

I can see someone sending me almost the indental revert patch right
after this one gets applied...

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-03-29 13:57    [W:0.084 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site