lkml.org 
[lkml]   [2018]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function
On Thu, Mar 29, 2018 at 01:21:14PM +0200, Hans de Goede wrote:
> --- a/include/linux/vbox_utils.h
> +++ b/include/linux/vbox_utils.h
> @@ -33,6 +33,13 @@ __printf(1, 2) void vbg_debug(const char *fmt, ...);
> */
> void *vbg_req_alloc(size_t len, enum vmmdev_request_type req_type);
>
> +/**
> + * Free a request allocated by vbg_req_alloc()
> + * @req: Request to free.
> + * @len: Length, must be the same as the value used for alloc.
> + */
> +void vbg_req_free(void *req, size_t len);
> +

Why is this in vbox_utils.h and not exported? Shouldn't you just put
this in drivers/virt/vboxguest/vboxguest_core.h?

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-03-29 13:57    [W:0.541 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site