Messages in this thread | | | Subject | Re: [PATCH v4 2/8] dt-bindings: ingenic: Add DT bindings for TCU clocks | Date | Wed, 28 Mar 2018 17:04:51 +0200 | From | Paul Cercueil <> | Subject | |
| |
Le 2018-03-20 08:15, Mathieu Malaterre a écrit : > Hi Paul, > > Two things: > > On Sun, Mar 18, 2018 at 12:28 AM, Paul Cercueil <paul@crapouillou.net> > wrote: >> This header provides clock numbers for the ingenic,tcu >> DT binding. > > I have tested the whole series on my Creator CI20 with success, using: > > + tcu@10002000 { > + compatible = "ingenic,jz4780-tcu"; > + reg = <0x10002000 0x140>; > + > + interrupt-parent = <&intc>; > + interrupts = <27 26 25>; > + }; > > > So: > > Tested-by: Mathieu Malaterre <malat@debian.org>
Great! Is that for the whole patchset or just this one patch?
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- >> include/dt-bindings/clock/ingenic,tcu.h | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 include/dt-bindings/clock/ingenic,tcu.h >> >> v2: Use SPDX identifier for the license >> v3: No change >> v4: No change >> >> diff --git a/include/dt-bindings/clock/ingenic,tcu.h >> b/include/dt-bindings/clock/ingenic,tcu.h >> new file mode 100644 >> index 000000000000..179815d7b3bb >> --- /dev/null >> +++ b/include/dt-bindings/clock/ingenic,tcu.h >> @@ -0,0 +1,23 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * This header provides clock numbers for the ingenic,tcu DT binding. >> + */ >> + >> +#ifndef __DT_BINDINGS_CLOCK_INGENIC_TCU_H__ >> +#define __DT_BINDINGS_CLOCK_INGENIC_TCU_H__ >> + >> +#define JZ4740_CLK_TIMER0 0 >> +#define JZ4740_CLK_TIMER1 1 >> +#define JZ4740_CLK_TIMER2 2 >> +#define JZ4740_CLK_TIMER3 3 >> +#define JZ4740_CLK_TIMER4 4 >> +#define JZ4740_CLK_TIMER5 5 >> +#define JZ4740_CLK_TIMER6 6 >> +#define JZ4740_CLK_TIMER7 7 >> +#define JZ4740_CLK_WDT 8 >> +#define JZ4740_CLK_LAST JZ4740_CLK_WDT >> + >> +#define JZ4770_CLK_OST 9 >> +#define JZ4770_CLK_LAST JZ4770_CLK_OST >> + > > When working on JZ4780 support, I always struggle to read those kind > of #define. Since this is a new patch would you mind changing > s/JZ4740/JZ47XX/ in your header ?
Well the idea was that these defines are for JZ4740 and newer. But that means all Ingenic SoCs, so I guess I can change it.
> Thanks for your work on JZ !
Sure, thank you for testing!
>> +#endif /* __DT_BINDINGS_CLOCK_INGENIC_TCU_H__ */ >> -- >> 2.11.0 >> >>
| |