lkml.org 
[lkml]   [2018]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] selftests/Makefile: append a slash to env variable OUTPUT
On Tue, Mar 27, 2018 at 03:19:26PM -0600, Shuah Khan wrote:
> On 03/26/2018 09:11 PM, changbin.du@intel.com wrote:
> > From: Changbin Du <changbin.du@intel.com>
> >
> > The tools/build/Makefile.build use 'OUTPUT' variable as below example:
> > objprefix := $(subst ./,,$(OUTPUT)$(dir)/)
> >
> > So it requires the 'OUTPUT' already has a slash at the end.
> >
> > This patch can kill below odd paths:
> > make[3]: Entering directory '/home/changbin/work/linux/tools/gpio'
> > CC /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio.o
> > CC /home/changbin/work/linux/tools/testing/selftests/gpiogpio-utils.o
> > LD /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio-in.o
> >
> > A correct path should be:
> > /home/changbin/work/linux/tools/testing/selftests/gpio/lsgpio.o
> >
> > Signed-off-by: Changbin Du <changbin.du@intel.com>
>
> Are you seeing this when you run "make kselftest" - if gpio is the
> only test compile that fails, it should be fixed in gpio/Makefile,
> not is the common Makefile.
>
I only saw error in gpio, but I also saw some kselftest Makefiles having string concatenation
as '$(OUTPUT)$(dir)'. So the rule is not aligned all over. They just didn't produce any errors
so far.

By the way, is there a basic test for kselftest infrastructure? It seems it was always
reporting error when building it :(

> thanks,
> -- Shuah

--
Thanks,
Changbin Du

\
 
 \ /
  Last update: 2018-03-28 03:55    [W:0.051 / U:7.600 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site