lkml.org 
[lkml]   [2018]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] watchdog: wafer5823wdt: Mark expected switch fall-through
    From
    Date
    On 03/27/2018 12:33 PM, Gustavo A. R. Silva wrote:
    > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    > where we are expecting to fall through.
    >
    > Notice that in this particular case I replaced "Fall" with a proper
    > "Fall through" comment, which is what GCC is expecting to find.
    >
    > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

    Reviewed-by: Guenter Roeck <linux@roeck-us.net>

    > ---
    > drivers/watchdog/wafer5823wdt.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/watchdog/wafer5823wdt.c b/drivers/watchdog/wafer5823wdt.c
    > index db0da7e..93c5b61 100644
    > --- a/drivers/watchdog/wafer5823wdt.c
    > +++ b/drivers/watchdog/wafer5823wdt.c
    > @@ -178,7 +178,7 @@ static long wafwdt_ioctl(struct file *file, unsigned int cmd,
    > timeout = new_timeout;
    > wafwdt_stop();
    > wafwdt_start();
    > - /* Fall */
    > + /* Fall through */
    > case WDIOC_GETTIMEOUT:
    > return put_user(timeout, p);
    >
    >

    \
     
     \ /
      Last update: 2018-03-27 23:07    [W:3.305 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site