lkml.org 
[lkml]   [2018]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/19] csky: Signal handling
On Mon, Mar 26, 2018 at 03:04:01PM +0200, Arnd Bergmann wrote:
> On Sun, Mar 18, 2018 at 8:51 PM, Guo Ren <ren_guo@c-sky.com> wrote:
> > Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> > ---
> > arch/csky/include/uapi/asm/sigcontext.h | 33 +++
> > arch/csky/include/uapi/asm/signal.h | 164 ++++++++++++++
> > arch/csky/kernel/signal.c | 379 ++++++++++++++++++++++++++++++++
> > 3 files changed, 576 insertions(+)
>
> Please have a look at arch/riscv and arch/nds32 for this, I think it can be
> simplified. This is an incompatible change of course, but when we change
> the system call ABI anyway, that is the right time to do it.
Ok.

>
>
> > +#define NSIG 32
> > +typedef unsigned long sigset_t;
> > +
> > +#endif /* __KERNEL__ */
> > +
> > +#define SIGHUP 1
> > +#define SIGINT 2
> > +#define SIGQUIT 3
> > +#define SIGILL 4
> > +#define SIGTRAP 5
> > +#define SIGABRT 6
> > +#define SIGIOT 6
> > +#define SIGBUS 7
> > +#define SIGFPE 8
> > +#define SIGKILL 9
> > +#define SIGUSR1 10
> > +#define SIGSEGV 11
> > +#define SIGUSR2 12
> > +#define SIGPIPE 13
>
> In particular the constants should come from the asm-generic headers
> rather than being duplicated. If you need anything special, it may be
> better to modify the generic headers.
Ok, use asm-generic.

Best Regards
Guo Ren

\
 
 \ /
  Last update: 2018-03-27 04:42    [W:0.060 / U:1.032 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site