lkml.org 
[lkml]   [2018]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: Use octal not symbolic permissions
On Mon, 26 Mar 2018, Joe Perches wrote:

> mm/*.c files use symbolic and octal styles for permissions.
>
> Using octal and not symbolic permissions is preferred by many as more
> readable.
>
> https://lkml.org/lkml/2016/8/2/1945
>
> Prefer the direct use of octal for permissions.
>
> Done using
> $ scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace mm/*.c
> and some typing.
>
> Before: $ git grep -P -w "0[0-7]{3,3}" mm | wc -l
> 44
> After: $ git grep -P -w "0[0-7]{3,3}" mm | wc -l
> 86
>
> Miscellanea:
>
> o Whitespace neatening around these conversions.
>
> Signed-off-by: Joe Perches <joe@perches.com>

Acked-by: David Rientjes <rientjes@google.com>

although extending some of these lines to be >80 characters also improves
the readability imo.

\
 
 \ /
  Last update: 2018-03-27 00:37    [W:0.064 / U:52.004 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site