lkml.org 
[lkml]   [2018]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4] tpm: separate cmd_ready/go_idle from runtime_pm
On Sat, Mar 24, 2018 at 09:39:35PM +0300, Tomas Winkler wrote:
> From: "Winkler, Tomas" <tomas.winkler@intel.com>
>
> We cannot use go_idle cmd_ready commands via runtime_pm handles
> as with the introduction of localities this is no longer an optional
> feature, while runtime pm can be not enabled.
> Though cmd_ready/go_idle provides power saving feature, it's also part of
> TPM2 protocol and should be called explicitly.
> This patch exposes cmd_read/go_idle via tpm class ops and removes
> runtime pm support as it is not used by any driver.
>
> tpm_crb no longer needs own power saving functions and can drop using
> tpm_pm_suspend/resume.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Still fails on Kabylake exactly the same way. With this I get
RC_UNBALANCED in these four test cases:

test_flush_context (tpm2_smoke.SpaceTest) ... ERROR
test_get_handles (tpm2_smoke.SpaceTest) ... ERROR
test_make_two_spaces (tpm2_smoke.SpaceTest) ... ERROR

Without this patch applied these errors do not occur.

/Jarkko

\
 
 \ /
  Last update: 2018-03-26 22:10    [W:0.028 / U:6.208 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site