lkml.org 
[lkml]   [2018]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] Ktest: use dodie for critical falures
From
Date
Thanks for the review Steve! One quick comment inline:

On 03/21/2018 08:16 AM, Steven Rostedt wrote:
> On Fri, 15 Dec 2017 15:20:10 -0800
> Tim Tianyang Chen <tianyang.chen@oracle.com> wrote:
>
>> Users should get emails when the script dies because of a critical failure. Critical
>> failures are defined as any errors that could abnormally terminate the script.
>>
>> In order to add email support, this patch converts all die() to dodie() except:
>> * when '-v' is used as an option to get the version of the script.
>> * in Sig-Int handeler because it's not a fatal error to cancel the script.
>> * errors happen during parsing config
> I would say you don't need it for parsing the config either. It doesn't
> make sense, as you wouldn't have the mailto defined yet.
>
Maybe it's the way I worded it. This patch coverts all die() to dodie()
_except_ these situations. So it doesn't send emails on config errors,
which is what you said here.
>> @@ -4132,7 +4132,7 @@ if ($#ARGV == 0) {
>> if (! -f $ktest_config) {
>> $newconfig = 1;
>> get_test_case;
>> - open(OUT, ">$ktest_config") or die "Can not create $ktest_config";
>> + open(OUT, ">$ktest_config") or dodie "Can not create $ktest_config";
> Here, no config was specified, and so no configs either.
>
>
>> print OUT << "EOF"
>> # Generated by ktest.pl
>> #
>> @@ -4167,7 +4167,7 @@ if (defined($opt{"LOG_FILE"})) {
>> my @new_configs = keys %entered_configs;
>> if ($#new_configs >= 0) {
>> print "\nAppending entered in configs to $ktest_config\n";
>> - open(OUT, ">>$ktest_config") or die "Can not append to $ktest_config";
>> + open(OUT, ">>$ktest_config") or dodie "Can not append to $ktest_config";
> Here too.
Right, I missed these two. I will send out v3 shortly.

Tim

\
 
 \ /
  Last update: 2018-03-26 20:49    [W:0.035 / U:23.492 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site