lkml.org 
[lkml]   [2018]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev
Hi David,

On Mon, Mar 26, 2018 at 11:38:30AM -0400, David Miller wrote:
> From: Moritz Fischer <mdf@kernel.org>
> Date: Fri, 23 Mar 2018 13:41:28 -0700
>
> > +static void nixge_hw_dma_bd_release(struct net_device *ndev)
> > +{
> > + int i;
> > + struct nixge_priv *priv = netdev_priv(ndev);
>
> Please order local variables from longest to shortest line (ie. reverse
> christmas tree layout).

Sure.
>
> > +static int nixge_hw_dma_bd_init(struct net_device *ndev)
> > +{
> > + u32 cr;
> > + int i;
> > + struct sk_buff *skb;
> > + struct nixge_priv *priv = netdev_priv(ndev);
>
> Likewise.

Sure.
>
> > +static void __nixge_device_reset(struct nixge_priv *priv, off_t offset)
> > +{
> > + u32 status;
> > + int err;
> > + /* Reset Axi DMA. This would reset NIXGE Ethernet core as well.
> > + * The reset process of Axi DMA takes a while to complete as all
> > + * pending commands/transfers will be flushed or completed during
> > + * this reset process.
> > + */
>
> Please put an empty line between the local variable declarations
> and this comment.

Will do in v6

Thanks for your review!

Cheers Moritz

\
 
 \ /
  Last update: 2018-03-26 17:57    [W:0.044 / U:15.548 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site