lkml.org 
[lkml]   [2018]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RT] Defer migrate_enable migration while task state != TASK_RUNNING
Oh well.  Makes me wonder why might_sleep is testing for
!TASK_RUNNABLE though.

Thanks for the correction,
Joe


On Mon, Mar 26, 2018 at 11:35:15AM -0400, Steven Rostedt wrote:
> On Fri, 23 Mar 2018 13:21:31 -0400
> joe.korty@concurrent-rt.com wrote:
>
> > My understanding is, in standard Linux and in rt, setting
> > task state to anything other than TASK_RUNNING in of itself
> > blocks preemption.
>
> That is clearly false. The only thing that blocks preemption with a
> CONFIG_PREEMPT kernel is preempt_disable() and local_irq*() disabling.
>
> (Note spin_locks call preempt_disable in non RT).
>
> Otherwise, nothing will stop preemption.
>
> > A preemption is not really needed here
> > as it is expected that there is a schedule() written in that
> > will shortly be executed. And if a 'involuntary schedule'
> > (ie, preemption) were allowed to occur between the task
> > state set and the schedule(), that would change the task
> > state back to TASK_RUNNING, which would cause the schedule
> > to NOP. Thus we risk not having paused long enough here
> > for the condition we were waiting for to become true.
>
> That is also incorrect. As Julia mentioned, a preemption keeps the
> state of the task.

\
 
 \ /
  Last update: 2018-03-26 17:55    [W:0.062 / U:7.032 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site