lkml.org 
[lkml]   [2018]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
On Fri, 23 Mar 2018 18:17:36 +0100
"bigeasy@linutronix.de" <bigeasy@linutronix.de> wrote:

> There are a few functions which check for if the lock is held
> (spin_lock_assert()) and the interrupts are disabled (irqs_disabled()).
> >From looking at the code, each function is static, the caller is near by
> and does spin_lock_irq|safe(). As Linus puts it:
>
> |It's not like this is some function that is exported to random users,
> |and we should check that the calling convention is right.
> |
> |This looks like "it may have been useful during coding to document
> |things, but it's not useful long-term".
>
> Remove those checks.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/target/target_core_tmr.c | 2 --
> drivers/target/target_core_transport.c | 6 ------
> 2 files changed, 8 deletions(-)
>
> diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c
> index 9c7bc1ca341a..3d35dad1de2c 100644
> --- a/drivers/target/target_core_tmr.c
> +++ b/drivers/target/target_core_tmr.c

Can you add a comment above the functions though?

/* Expects to have se_cmd->se_sess->sess_cmd_lock held */

> @@ -114,8 +114,6 @@ static bool __target_check_io_state(struct se_cmd *se_cmd,
> {
> struct se_session *sess = se_cmd->se_sess;
>
> - assert_spin_locked(&sess->sess_cmd_lock);
> - WARN_ON_ONCE(!irqs_disabled());
> /*
> * If command already reached CMD_T_COMPLETE state within
> * target_complete_cmd() or CMD_T_FABRIC_STOP due to shutdown,
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 74b646f165d4..2c3ddb3a4124 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c

/* Expects to have cmd->t_state_lock held */

> @@ -2954,9 +2954,6 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop,
> __acquires(&cmd->t_state_lock)
> {
>
> - assert_spin_locked(&cmd->t_state_lock);
> - WARN_ON_ONCE(!irqs_disabled());
> -
> if (fabric_stop)
> cmd->transport_state |= CMD_T_FABRIC_STOP;
>

/* Expects to have cmd->t_state_lock held */

> @@ -3241,9 +3238,6 @@ static int __transport_check_aborted_status(struct se_cmd *cmd, int send_status)
> {
> int ret;
>
> - assert_spin_locked(&cmd->t_state_lock);
> - WARN_ON_ONCE(!irqs_disabled());
> -
> if (!(cmd->transport_state & CMD_T_ABORTED))
> return 0;
> /*

-- Steve

\
 
 \ /
  Last update: 2018-03-26 17:14    [W:0.089 / U:7.268 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site