lkml.org 
[lkml]   [2018]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]cgroup: __cpuset_node_allowed return bool
Hi Tejun,

inline.

On 2018-03-26 10:25 PM, Tejun Heo wrote:
> On Mon, Mar 26, 2018 at 10:20:43PM +0800, yuankuiz@codeaurora.org
> wrote:
>> 1) return int type variable in bool function:
>> bool enabled()
>> {
>> int ret = 1;
>> return ret;
>> }
> ...
>> 2)
>> bool enabled()
>> {
>> bool ret = 1;
>> return ret;
>> }
> ...
>> so the #1) style function can generate significant instructions
>> than the #2).
>
> That is a problem for the compiler, not the code.
>
>> While, this is happened only when "-On" is not used with *-gcc
>> together. Though, it is oftern there, it is best to provide this
>> with decoupling of which option is used for optimization.
>
> We don't want to dictate minute coding styles to avoid things which
> are trivially optimized by compilers.
[ZJ] Optimized by compiler is observed only. Such as it is not so big
difference in x86-arch.

>
> Thanks.

\
 
 \ /
  Last update: 2018-03-26 16:38    [W:0.042 / U:21.256 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site