lkml.org 
[lkml]   [2018]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/8] staging:iio:ade7854: Fix the wrong number of bits to read
On Fri, 23 Mar 2018 11:25:48 -0300
John Syne <rodrigosiqueiramelo@gmail.com> wrote:

> Fixes: correctly handle the data size in the read operation for I2C
>
> The function ade7854_i2c_read_reg_32() have to invoke the
> i2c_master_recv() for read 32 bits values, however, the counter is set
> to 3 which means 24 bits. This patch fixes the wrong size of 24 bits, to
> 32 bits.
>
> Signed-off-by: John Syne <john3909@gmail.com>
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Applied with fixed 'fixes' tag.

Jonathan

> ---
> Changes in v3:
> - Clarify authorship
> - Add Fixes tag in the commit message
>
> drivers/staging/iio/meter/ade7854-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index 4437f1e33261..37c957482493 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -191,7 +191,7 @@ static int ade7854_i2c_read_reg_32(struct device *dev,
> if (ret < 0)
> goto out;
>
> - ret = i2c_master_recv(st->i2c, st->rx, 3);
> + ret = i2c_master_recv(st->i2c, st->rx, 4);
> if (ret < 0)
> goto out;
>

\
 
 \ /
  Last update: 2018-03-24 14:23    [W:0.072 / U:5.100 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site