lkml.org 
[lkml]   [2018]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [2/4] scsi: hpsa: Less function calls in hpsa_big_passthru_ioctl() after error detection
From
Date
>> @@ -6501,14 +6501,16 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info
>> *h, void __user *argp)
>> cleanup0:
>> cmd_free(h, c);
>> cleanup1:
>> - if (buff) {
>> + {
>> int i;
>>
>> for (i = 0; i < sg_used; i++)
>> kfree(buff[i]);
>> kfree(buff);
>> }
>
> Thanks for looking at the hpsa driver.
>
> This HUNK ends up with an unnamed block.

Which identifier would you like to use there?


> I would prefer to not have it structured like this.

Would you like to show a source code layout alternative?

Regards,
Markus

\
 
 \ /
  Last update: 2018-03-24 10:02    [W:0.051 / U:15.480 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site