lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 25/77] dmaengine: zynqmp_dma: Fix race condition in the probe
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kedareswara rao Appana <appana.durga.rao@xilinx.com>


    [ Upstream commit 5ba080aada5e739165e0f38d5cc3b04c82b323c8 ]

    Incase of interrupt property is not present,
    Driver is trying to free an invalid irq,
    This patch fixes it by adding a check before freeing the irq.

    Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
    Signed-off-by: Vinod Koul <vinod.koul@intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/dma/xilinx/zynqmp_dma.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/dma/xilinx/zynqmp_dma.c
    +++ b/drivers/dma/xilinx/zynqmp_dma.c
    @@ -838,7 +838,8 @@ static void zynqmp_dma_chan_remove(struc
    if (!chan)
    return;

    - devm_free_irq(chan->zdev->dev, chan->irq, chan);
    + if (chan->irq)
    + devm_free_irq(chan->zdev->dev, chan->irq, chan);
    tasklet_kill(&chan->tasklet);
    list_del(&chan->common.device_node);
    clk_disable_unprepare(chan->clk_apb);

    \
     
     \ /
      Last update: 2018-03-23 12:56    [W:4.518 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site