lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 40/97] mmc: host: omap_hsmmc: checking for NULL instead of IS_ERR()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>


    [ Upstream commit ec5ab8933772c87f24ad62a4a602fe8949f423c2 ]

    devm_pinctrl_get() returns error pointers, it never returns NULL.

    Fixes: 455e5cd6f736 ("mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/mmc/host/omap_hsmmc.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/mmc/host/omap_hsmmc.c
    +++ b/drivers/mmc/host/omap_hsmmc.c
    @@ -1776,8 +1776,8 @@ static int omap_hsmmc_configure_wake_irq
    */
    if (host->pdata->controller_flags & OMAP_HSMMC_SWAKEUP_MISSING) {
    struct pinctrl *p = devm_pinctrl_get(host->dev);
    - if (!p) {
    - ret = -ENODEV;
    + if (IS_ERR(p)) {
    + ret = PTR_ERR(p);
    goto err_free_irq;
    }
    if (IS_ERR(pinctrl_lookup_state(p, PINCTRL_STATE_DEFAULT))) {

    \
     
     \ /
      Last update: 2018-03-23 11:48    [W:4.220 / U:1.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site