Messages in this thread | | | Subject | Re: [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN devices | From | Jakob Unterwurzacher <> | Date | Fri, 23 Mar 2018 10:40:01 +0100 |
| |
On 23.03.18 09:32, Wolfgang Grandegger wrote: >> * add __func__ to all errors and warnings, and to info where it made sense > > The final output messages in the driver should especially be useful for > the end user... and not the developer! This is also true for the > function names. You already use more "__func__" than all other CAN > drivers together. Just my opinion!
The idea was to make it clear which driver printed the message. In my opinion, this is a problem:
> drivers/net/can/usb$ git grep "No memory left for USB buffer" > ems_usb.c: netdev_err(netdev, "No memory left for USB buffer\n"); > ems_usb.c: netdev_err(netdev, "No memory left for USB buffer\n"); > esd_usb2.c: "No memory left for USB buffer\n"); > esd_usb2.c: netdev_err(netdev, "No memory left for USB buffer\n"); > gs_usb.c: netdev_err(netdev, "No memory left for USB buffer\n"); > gs_usb.c: "No memory left for USB buffer\n"); > kvaser_usb.c: "No memory left for USB buffer\n"); > mcba_usb.c: netdev_err(netdev, "No memory left for USB buffer\n"); > usb_8dev.c: netdev_err(netdev, "No memory left for USB buffer\n"); > usb_8dev.c: netdev_err(netdev, "No memory left for USB buffer\n");
But I'm open to other suggestions (use a fixed "ucan: " prefix?) or to drop it entirely if you think it is not worth it.
Thanks for the feedback, Jakob
| |