lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] swiotlb: swiotlb_{alloc,free}_buffer should depend on CONFIG_DMA_DIRECT_OPS
    On Fri, 23 Mar 2018, Konrad Rzeszutek Wilk wrote:

    > On Fri, Mar 23, 2018 at 06:49:30PM +0100, Christoph Hellwig wrote:
    > > Otherwise we might get unused symbol warnings for configs that built
    > > swiotlb.c only for use by xen-swiotlb.c and that don't otherwise select
    > > CONFIG_DMA_DIRECT_OPS, which is possible on arm.
    > >
    > > Fixes: 16e73adbca76 ("dma/swiotlb: Remove swiotlb_{alloc,free}_coherent()")
    > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    > > Signed-off-by: Christoph Hellwig <hch@lst.de>
    >
    >
    > Alternatively could we set the Kconfig to slect DMA_DIRECT_OPS?

    You only want to do that when you actually need the code. If not it's a
    pointless exercise.

    But Christoph change makes sense independent of that because the next
    oddball Kconfig will come along sooner than later and run into the very
    same problem.

    Thanks,

    tglx

    \
     
     \ /
      Last update: 2018-03-23 20:42    [W:3.134 / U:2.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site