lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 05/21] tracing: probeevent: Cleanup print argument functions
On Sat, 17 Mar 2018 21:41:12 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Current print argument functions prints the argument
> name too. It is not good for printing out multiple
> values for one argument. This change it to just print
> out the value.

Hi Masami,

This is a confusing change log, as I have no idea what this patch does.
Can you add a "before" and "after" of what you mean. Some examples of
what it currently does to show why it looks bad, and then an example of
what it looks like after the patch.

Thanks!

-- Steve


>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
>

\
 
 \ /
  Last update: 2018-03-23 17:37    [W:0.105 / U:21.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site