Messages in this thread | | | From | Masahiro Yamada <> | Date | Fri, 23 Mar 2018 00:13:38 +0900 | Subject | Re: [PATCH 2/3] checkpatch: kconfig: check help texts for menuconfig and choice |
| |
2018-02-17 5:22 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>: > Currently, only Kconfig symbols are checked for a missing or short help > text, and are only checked if they are defined with the 'config' > keyword. > > To make the check more general, extend it to also check help texts for > choices and for symbols defined with the 'menuconfig' keyword. > > This increases the accuracy of the check for symbols that would already > have been checked as well, since e.g. a 'menuconfig' symbol after a help > text will be recognized as ending the preceding symbol/choice > definition. > > To increase the accuracy of the check further, also recognize 'if', > 'endif', 'menu', 'endmenu', 'endchoice', and 'source' as ending a > symbol/choice definition.
Currently, this is not checked for the last symbol in a file. Perhaps, EOF could be also an ending of symbol definition.
This patch is a good improvement enough, so I queued it up.
If you have an idea for further improvement, v2 is welcome, of course.
-- Best Regards Masahiro Yamada
| |