Messages in this thread | | | Subject | Re: [PATCH v2] Bluetooth: Remove VLA usage in aes_cmac | From | "Gustavo A. R. Silva" <> | Date | Wed, 21 Mar 2018 08:49:44 -0500 |
| |
On 03/21/2018 08:45 AM, Marcel Holtmann wrote: > Hi Gustavo, > >> In preparation to enabling -Wvla, remove VLA and replace it >> with dynamic memory allocation instead. >> >> The use of stack Variable Length Arrays needs to be avoided, as they >> can be a vector for stack exhaustion, which can be both a runtime bug >> or a security flaw. Also, in general, as code evolves it is easy to >> lose track of how big a VLA can get. Thus, we can end up having runtime >> failures that are hard to debug. >> >> Also, fixed as part of the directive to remove all VLAs from >> the kernel: https://lkml.org/lkml/2018/3/7/621 >> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> --- >> Changes in v2: >> - Fix memory leak in previous patch. >> >> net/bluetooth/smp.c | 17 ++++++++++++----- >> 1 file changed, 12 insertions(+), 5 deletions(-) > > patch has been applied to bluetooth-next tree. > > Regards > > Marcel >
Awesome.
Thanks, Marcel. -- Gustavo
| |