lkml.org 
[lkml]   [2018]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/9] aio: remove an outdated comment in aio_complete
    On Wed, Mar 21, 2018 at 08:32:25AM +0100, Christoph Hellwig wrote:
    > These days we don't treat sync iocbs special in the aio completion code as
    > they never use it. Remove the old comment, and move the BUG_ON for a sync
    > iocb to the top of the function.
    >
    > Signed-off-by: Christoph Hellwig <hch@lst.de>
    > Acked-by: Jeff Moyer <jmoyer@redhat.com>
    > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    > ---
    > fs/aio.c | 11 ++---------
    > 1 file changed, 2 insertions(+), 9 deletions(-)
    >
    > diff --git a/fs/aio.c b/fs/aio.c
    > index 03d59593912d..41fc8ce6bc7f 100644
    > --- a/fs/aio.c
    > +++ b/fs/aio.c
    > @@ -1088,6 +1088,8 @@ static void aio_complete(struct kiocb *kiocb, long res, long res2)
    > unsigned tail, pos, head;
    > unsigned long flags;
    >
    > + BUG_ON(is_sync_kiocb(kiocb));

    Is this BUG_ON even needed anymore? Does it ever trip in any "regular"
    use, or is it only there for when a developer does something dumb? If
    "dumb", then we should keep it, otherwise we might be able to just drop
    it.

    Either way, this patch is fine:

    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    \
     
     \ /
      Last update: 2018-03-21 10:14    [W:4.031 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site