Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 21 Mar 2018 09:06:50 +0100 | Subject | Re: [PATCH v2] spi: rspi: use correct enum for DMA transfer direction |
| |
Hi Stefan,
On Mon, Mar 19, 2018 at 11:16 PM, Stefan Agner <stefan@agner.ch> wrote: > Use enum dma_transfer_direction as required by dmaengine_prep_slave_sg > instead of enum dma_data_direction. This won't change behavior in > practice as the enum values are equivalent.
Thanks for catching!
BTW, spi-sh-msiof has the same issue. Will sent a fix.
> This fixes two warnings when building with clang: > drivers/spi/spi-rspi.c:538:26: warning: implicit conversion from enumeration > type 'enum dma_data_direction' to different enumeration type > 'enum dma_transfer_direction' [-Wenum-conversion] > rx->sgl, rx->nents, DMA_FROM_DEVICE, > ^~~~~~~~~~~~~~~ > drivers/spi/spi-rspi.c:558:26: warning: implicit conversion from enumeration > type 'enum dma_data_direction' to different enumeration type > 'enum dma_transfer_direction' [-Wenum-conversion] > tx->sgl, tx->nents, DMA_TO_DEVICE, > ^~~~~~~~~~~~~ > > Signed-off-by: Stefan Agner <stefan@agner.ch>
JFTR, as it's already applied Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |