lkml.org 
[lkml]   [2018]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 答复: 答复: [PATCH] mm/memcontrol.c: speed up to force empty a memory cgroup
On Wed, 21 Mar 2018, Andrey Ryabinin wrote:

> > Is SWAP_CLUSTER_MAX the best answer if I'm lowering the limit by 1GB?
> >
>
> Absolutely not. I completely on your side here.
> I've tried to fix this recently - http://lkml.kernel.org/r/20180119132544.19569-2-aryabinin@virtuozzo.com
> I guess that Andrew decided to not take my patch, because Michal wasn't
> happy about it (see mail archives if you want more details).
>

I unfortunately didn't see this patch in January, it seems very similar to
what I was suggesting in this thread. You do a page_counter_read()
directly in mem_cgroup_resize_limit() where my suggestion was to have
page_counter_limit() return the difference, but there's nothing
significantly different about what you proposed and what I suggested.

Perhaps the patch would be better off as a compromise between what you, I,
and Li RongQing have proposed/suggested: have page_counter_limit() return
the difference, and clamp it to some value proportional to the new limit.

\
 
 \ /
  Last update: 2018-03-20 23:46    [W:0.069 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site