lkml.org 
[lkml]   [2018]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf c2c report: Call calc_width() only for displayed entries
    Commit-ID:  bc229c21f2c79ef0f7b30d3a2fce8c2886ffa6c7
    Gitweb: https://git.kernel.org/tip/bc229c21f2c79ef0f7b30d3a2fce8c2886ffa6c7
    Author: Jiri Olsa <jolsa@kernel.org>
    AuthorDate: Fri, 9 Mar 2018 11:14:39 +0100
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Fri, 16 Mar 2018 13:53:13 -0300

    perf c2c report: Call calc_width() only for displayed entries

    There's no need to calculate column widths for entries that are not
    going to be displayed.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Joe Mario <jmario@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/20180309101442.9224-7-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-c2c.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
    index 43ce55550c9d..821112e8ba97 100644
    --- a/tools/perf/builtin-c2c.c
    +++ b/tools/perf/builtin-c2c.c
    @@ -1873,12 +1873,11 @@ static int resort_cl_cb(struct hist_entry *he)
    c2c_he = container_of(he, struct c2c_hist_entry, he);
    c2c_hists = c2c_he->hists;

    - calc_width(c2c_he);
    -
    if (display && c2c_hists) {
    static unsigned int idx;

    c2c_he->cacheline_idx = idx++;
    + calc_width(c2c_he);

    c2c_hists__reinit(c2c_hists, c2c.cl_output, c2c.cl_resort);

    \
     
     \ /
      Last update: 2018-03-20 07:21    [W:4.352 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site