lkml.org 
[lkml]   [2018]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v6 16/20] clk: add support for clocks provided by SCMI
    From
    Date


    On 16/03/18 23:02, Stephen Boyd wrote:
    > Quoting Sudeep Holla (2018-02-23 08:23:46)
    >> diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c
    >> new file mode 100644
    >> index 000000000000..1e4d7a57779b
    >> --- /dev/null
    >> +++ b/drivers/clk/clk-scmi.c
    >> + hws[idx] = &sclk->hw;
    >> + }
    >> + }
    >> +
    >> + return of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_data);
    >
    > devm_of_clk_add_hw_provider?
    >

    Thanks for noticing this, I wasn't aware of it's addition. This patch
    predates that :(

    >> +}
    >> +
    >> +static void scmi_clocks_remove(struct scmi_device *sdev)
    >> +{
    >> + struct device *dev = &sdev->dev;
    >> + struct device_node *np = dev->of_node;
    >> +
    >> + of_clk_del_provider(np);
    >> +}
    >> +
    >
    > Drop?
    >

    Sure, I will have to do these changes as add-on patch as this original
    patch is already queued in ARM SoC tree for v4.17

    > You can keep my acked-by otherwise.
    >

    Thanks.

    --
    Regards,
    Sudeep

    \
     
     \ /
      Last update: 2018-03-20 13:09    [W:3.117 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site