lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 05/12] clk: actions: Add gate clock support
Date
Quoting Manivannan Sadhasivam (2018-03-17 03:09:45)
> diff --git a/drivers/clk/actions/owl-gate.c b/drivers/clk/actions/owl-gate.c
> new file mode 100644
> index 000000000000..25dd94ac0f35
> --- /dev/null
> +++ b/drivers/clk/actions/owl-gate.c
> @@ -0,0 +1,77 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// OWL gate clock driver
> +//
> +// Copyright (c) 2014 Actions Semi Inc.
> +// Author: David Liu <liuwei@actions-semi.com>
> +//
> +// Copyright (c) 2018 Linaro Ltd.
> +// Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> +
> +#include <linux/clk-provider.h>
> +#include <linux/regmap.h>
> +
> +#include "owl-gate.h"
> +
> +void clk_gate_set(const struct owl_clk_common *common,

owl_gate_set?

> + const struct owl_gate_hw *gate_hw, bool enable)
> +{
> + int set = gate_hw->gate_flags & CLK_GATE_SET_TO_DISABLE ? 1 : 0;
> + u32 reg;
> +
> + set ^= enable;
> +
> + regmap_read(common->regmap, gate_hw->reg, &reg);
> +
> + if (set)
> + reg |= BIT(gate_hw->bit_idx);
> + else
> + reg &= ~BIT(gate_hw->bit_idx);
> +
> + regmap_write(common->regmap, gate_hw->reg, reg);
> +}
> +
> +static void owl_gate_disable(struct clk_hw *hw)
> +{
> + struct owl_gate *gate = hw_to_owl_gate(hw);
> + struct owl_clk_common *common = &gate->common;
> +
> + clk_gate_set(common, &gate->gate_hw, false);
> +}
> +
> +static int owl_gate_enable(struct clk_hw *hw)
> +{
> + struct owl_gate *gate = hw_to_owl_gate(hw);
> + struct owl_clk_common *common = &gate->common;
> +
> + clk_gate_set(common, &gate->gate_hw, true);
> +
> + return 0;
> +}
> +
> +int clk_is_enabled(const struct owl_clk_common *common,

Can this be called owl_gate_is_enabled?

> + const struct owl_gate_hw *gate_hw)
> +{
> + u32 reg;
> +
> + regmap_read(common->regmap, gate_hw->reg, &reg);
> +
> + if (gate_hw->gate_flags & CLK_GATE_SET_TO_DISABLE)
> + reg ^= BIT(gate_hw->bit_idx);
> +
> + return !!(reg & BIT(gate_hw->bit_idx));
> +}
> +
> +static int owl_gate_is_enabled(struct clk_hw *hw)
> +{
> + struct owl_gate *gate = hw_to_owl_gate(hw);
> + struct owl_clk_common *common = &gate->common;
> +
> + return clk_is_enabled(common, &gate->gate_hw);
> +}
> +
> +const struct clk_ops owl_gate_ops = {

Everything going to be builtin? If anything is a module then this needs
to be exported.

> + .disable = owl_gate_disable,
> + .enable = owl_gate_enable,
> + .is_enabled = owl_gate_is_enabled,
> +};

Otherwise looks good.

\
 
 \ /
  Last update: 2018-03-20 02:05    [W:0.156 / U:9.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site