lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.15 013/124] net: hns3: free the ring_data structrue when change tqps
    Date
    From: Peng Li <lipeng321@huawei.com>

    [ Upstream commit 99fdf6b1cadf41bb253408589788f025027274f3 ]

    This patch fixes a memory leak problems in change tqps process,
    the function hns3_uninit_all_ring and hns3_init_all_ring
    may be called many times.

    Signed-off-by: Peng Li <lipeng321@huawei.com>
    Signed-off-by: Mingguang Qu <qumingguang@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
    index 59415090ff0f..853f273da22d 100644
    --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
    @@ -2785,8 +2785,12 @@ int hns3_uninit_all_ring(struct hns3_nic_priv *priv)
    h->ae_algo->ops->reset_queue(h, i);

    hns3_fini_ring(priv->ring_data[i].ring);
    + devm_kfree(priv->dev, priv->ring_data[i].ring);
    hns3_fini_ring(priv->ring_data[i + h->kinfo.num_tqps].ring);
    + devm_kfree(priv->dev,
    + priv->ring_data[i + h->kinfo.num_tqps].ring);
    }
    + devm_kfree(priv->dev, priv->ring_data);

    return 0;
    }
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-19 23:40    [W:4.054 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site