Messages in this thread | | | From | "Michael Kelley (EOSG)" <> | Subject | RE: [PATCH] vmbus: use put_device() if device_register fail | Date | Sun, 18 Mar 2018 22:37:06 +0000 |
| |
> -----Original Message----- > From: linux-kernel-owner@vger.kernel.org <linux-kernel-owner@vger.kernel.org> On Behalf > Of Arvind Yadav > Sent: Saturday, March 17, 2018 11:48 PM > To: Stephen Hemminger <sthemmin@microsoft.com>; Haiyang Zhang > <haiyangz@microsoft.com> > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org > Subject: [PATCH] vmbus: use put_device() if device_register fail > > if device_register() returned an error. Always use put_device() > to give up the reference initialized. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> --- > drivers/hv/vmbus_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index bc65c4d..25da2f3 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -1358,6 +1358,7 @@ int vmbus_device_register(struct hv_device *child_device_obj) > ret = device_register(&child_device_obj->device); > if (ret) { > pr_err("Unable to register child device\n"); > + put_device(&child_device_obj->device); > return ret; > } > > -- > 2.7.4
| |