lkml.org 
[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 037/109] staging: rtl8822be: fix missing null check on dev_alloc_skb return
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>


    [ Upstream commit 3eb23426e1749a0483bc4c9b18e51f657569e3ed ]

    dev_alloc_skb can potentially return NULL, so add a null check to
    avoid a null pointer dereference on skb

    Detected by CoverityScan, CID#1454558 ("Dereference on null return")

    Fixes: 7e5b796cde7e ("staging: r8822be: Add the driver code")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/rtlwifi/rtl8822be/fw.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/staging/rtlwifi/rtl8822be/fw.c
    +++ b/drivers/staging/rtlwifi/rtl8822be/fw.c
    @@ -464,6 +464,8 @@ bool rtl8822b_halmac_cb_write_data_rsvd_
    int count;

    skb = dev_alloc_skb(size);
    + if (!skb)
    + return false;
    memcpy((u8 *)skb_put(skb, size), buf, size);

    if (!_rtl8822be_send_bcn_or_cmd_packet(rtlpriv->hw, skb, BEACON_QUEUE))

    \
     
     \ /
      Last update: 2018-03-16 17:47    [W:4.145 / U:0.484 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site