lkml.org 
[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 09/61] xarray: Replace exceptional entries
On Fri, Mar 16, 2018 at 02:53:50PM -0400, Josef Bacik wrote:
> On Tue, Mar 13, 2018 at 06:25:47AM -0700, Matthew Wilcox wrote:
> > @@ -453,18 +449,14 @@ int ida_get_new_above(struct ida *ida, int start, int *id)
> > new += bit;
> > if (new < 0)
> > return -ENOSPC;
> > - if (ebit < BITS_PER_LONG) {
> > - bitmap = (void *)((1UL << ebit) |
> > - RADIX_TREE_EXCEPTIONAL_ENTRY);
> > - radix_tree_iter_replace(root, &iter, slot,
> > - bitmap);
> > - *id = new;
> > - return 0;
> > + if (bit < BITS_PER_XA_VALUE) {
> > + bitmap = xa_mk_value(1UL << bit);
> > + } else {
> > + bitmap = this_cpu_xchg(ida_bitmap, NULL);
> > + if (!bitmap)
> > + return -EAGAIN;
> > + __set_bit(bit, bitmap->bitmap);
> > }
> > - bitmap = this_cpu_xchg(ida_bitmap, NULL);
> > - if (!bitmap)
> > - return -EAGAIN;
> > - __set_bit(bit, bitmap->bitmap);
> > radix_tree_iter_replace(root, &iter, slot, bitmap);
> > }
> >
>
> This threw me off a bit, but we do *id = new below.

Yep. Fortunately, I have a test-suite for the IDA, so I'm relatively
sure this works.

> > @@ -495,9 +487,9 @@ void ida_remove(struct ida *ida, int id)
> > goto err;
> >
> > bitmap = rcu_dereference_raw(*slot);
> > - if (radix_tree_exception(bitmap)) {
> > + if (xa_is_value(bitmap)) {
> > btmp = (unsigned long *)slot;
> > - offset += RADIX_TREE_EXCEPTIONAL_SHIFT;
> > + offset += 1; /* Intimate knowledge of the xa_data encoding */
> > if (offset >= BITS_PER_LONG)
> > goto err;
> > } else {
>
> Ick.

I know. I feel quite ashamed of this code. I do have a rewrite to use
the XArray, but I didn't want to include it as part of *this* merge request.
And that rewrite decodes the value into an unsigned long, sets the bit,
reencodes it as an xa_value and stores it.

> > @@ -393,11 +393,11 @@ void ida_check_conv(void)
> > for (i = 0; i < 1000000; i++) {
> > int err = ida_get_new(&ida, &id);
> > if (err == -EAGAIN) {
> > - assert((i % IDA_BITMAP_BITS) == (BITS_PER_LONG - 2));
> > + assert((i % IDA_BITMAP_BITS) == (BITS_PER_LONG - 1));
> > assert(ida_pre_get(&ida, GFP_KERNEL));
> > err = ida_get_new(&ida, &id);
> > } else {
> > - assert((i % IDA_BITMAP_BITS) != (BITS_PER_LONG - 2));
> > + assert((i % IDA_BITMAP_BITS) != (BITS_PER_LONG - 1));
>
> Can we just use BITS_PER_XA_VALUE here?

Yes! I'll change that.

> Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks!

\
 
 \ /
  Last update: 2018-03-16 20:07    [W:0.057 / U:17.528 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site