Messages in this thread | | | Subject | Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses | From | Joe Perches <> | Date | Thu, 15 Mar 2018 07:48:30 -0700 |
| |
On Thu, 2018-03-15 at 14:22 +0100, Maarten Lankhorst wrote: > Op 13-03-18 om 23:02 schreef Joe Perches: > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > > arguments that can be removed by creating separate functins. > > > > Create specific functions for these calls to reduce x86/64 defconfig > > size by ~20k. > > > > Modify the existing macros to use the specific calls. > > > > new: > > $ size -t drivers/gpu/drm/built-in.a | tail -1 > > 1876562 44542 995 1922099 1d5433 (TOTALS) > > > > old: > > $ size -t drivers/gpu/drm/built-in.a | tail -1 > > 1897565 44542 995 1943102 1da63e (TOTALS) [] > I guess this adds up. Nice reduction. :)
Yup. 1% of all drm object code.
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c [] > > > > - drm_printk(level, category, "mismatch in %s %pV", name, &vaf); > > + if (adjust) > > + drm_dbg(DRM_UT_KMS, "mismatch in %s %pV", name, &vaf); > > + else > > + drm_err("mismatch in %s %pV", name, &vaf); > > Could this use DRM_DEBUG_KMS/DRM_ERROR? > > Rest looks good, so I can fix up if you want.
If want you change something like that, it should be separate patch.
btw: There was separate patch that also reduced object size of the drm_dev_printk calls several months ago. Never applied.
https://lkml.org/lkml/2017/9/25/247
cheers, Joe
| |