Messages in this thread | | | From | Dan Williams <> | Date | Thu, 15 Mar 2018 07:24:37 -0700 | Subject | Re: [PATCH 0/3] Introduce module_nd_driver |
| |
On Thu, Mar 15, 2018 at 1:11 AM, Johannes Thumshirn <jthumshirn@suse.de> wrote: > On Thu, Mar 15, 2018 at 12:22:57AM -0700, Christoph Hellwig wrote: >> What is the point? It saves a hand fulk of lines, while making >> the code both harder to read and harder to extend. > > In the end it's just style alignment with most of the other "busses" > in the kernel, like pci, of, acpi, platform and so on... > > But yes I admit it's not a huge win. For the harder to read part, I > doubt it. A quick: > git grep -E module_.*._driver drivers/ | wc -l > has 3896 hit's, so it's not that uncommon ;-) > > But anyways, it's just code churn I came up with while being > frustrated hunting down a bug in this subsystem. >
Works for me. Removing more lines than you add is always welcome.
| |