lkml.org 
[lkml]   [2018]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10] mmc: Export host capabilities to debugfs.
From
Date
On Thu, 2018-03-15 at 13:29 +0100, Ulf Hansson wrote:
> On 15 March 2018 at 11:26, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, 2018-03-15 at 11:12 +0100, Ulf Hansson wrote:
> > > On 13 March 2018 at 06:10, Harish Jenny K N <harish_kandiga@mentor
> > > .com
> > > > wrote:
> > > >
> > > Honestly, I don't like this, but maybe other people do, then I am
> > > fine
> > > with this approach.
> > >
> > > If were to decide, I would just rather print the caps field in a
> > > hexadecimal bit form and leave the translation to the user.
> >
> > A compromise would be to print both:
> >
> > 0xHHHHHHHH\n
> > Description of each enabled field, one per line
> >
> >
> > Another format would be:
> >
> > Bit XX: Description of a field
>
> If we were to print the description, there is no point in printing the
> bits in hex. Or is it?

It is helpful for scripting (since it's debugfs, under scripting I mean
something rather for test suites than for actual use).

> As I said, if you and other folkz thinks this is valuable, then I am
> fine as well. Just saying, it's not my preferred option.

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

\
 
 \ /
  Last update: 2018-03-15 14:02    [W:0.058 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site