lkml.org 
[lkml]   [2018]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 6/7] staging: pi433: fix CamelCase for lnaGain enum
    Fixes checkpatch warning:

    CHECK: Avoid CamelCase: <lnaGain>

    Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
    ---
    drivers/staging/pi433/Documentation/pi433.txt | 2 +-
    drivers/staging/pi433/pi433_if.h | 2 +-
    drivers/staging/pi433/rf69.c | 4 ++--
    drivers/staging/pi433/rf69.h | 2 +-
    drivers/staging/pi433/rf69_enum.h | 2 +-
    5 files changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/staging/pi433/Documentation/pi433.txt b/drivers/staging/pi433/Documentation/pi433.txt
    index 79bccc586869..3bb38644eb6e 100644
    --- a/drivers/staging/pi433/Documentation/pi433.txt
    +++ b/drivers/staging/pi433/Documentation/pi433.txt
    @@ -196,7 +196,7 @@ rf params:
    sets the electrical adoption of the antenna
    fifty_ohm - for antennas with an impedance of 50Ohm
    two_hundred_ohm - for antennas with an impedance of 200Ohm
    - lnaGain
    + lna_gain
    sets the gain of the low noise amp
    automatic - lna gain is determined by an agc
    max - lna gain is set to maximum
    diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
    index be4a96055a97..b6e214c29ddf 100644
    --- a/drivers/staging/pi433/pi433_if.h
    +++ b/drivers/staging/pi433/pi433_if.h
    @@ -117,7 +117,7 @@ struct pi433_rx_cfg {
    __u8 rssi_threshold;
    enum threshold_decrement threshold_decrement;
    enum antenna_impedance antenna_impedance;
    - enum lnaGain lna_gain;
    + enum lna_gain lna_gain;
    enum mantisse bw_mantisse; /* normal: 0x50 */
    __u8 bw_exponent; /* during AFC: 0x8b */
    enum dagc dagc;
    diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
    index e3394094f6a1..0bc459e32f6b 100644
    --- a/drivers/staging/pi433/rf69.c
    +++ b/drivers/staging/pi433/rf69.c
    @@ -399,9 +399,9 @@ int rf69_set_antenna_impedance(struct spi_device *spi, enum antenna_impedance an
    }
    }

    -int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain)
    +int rf69_set_lna_gain(struct spi_device *spi, enum lna_gain lna_gain)
    {
    - switch (lnaGain) {
    + switch (lna_gain) {
    case automatic:
    return rf69_read_mod_write(spi, REG_LNA, MASK_LNA_GAIN, LNA_GAIN_AUTO);
    case max:
    diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
    index 4d6fc07f8255..b9f6850e3316 100644
    --- a/drivers/staging/pi433/rf69.h
    +++ b/drivers/staging/pi433/rf69.h
    @@ -37,7 +37,7 @@ int rf69_disable_amplifier(struct spi_device *spi, u8 amplifier_mask);
    int rf69_set_output_power_level(struct spi_device *spi, u8 power_level);
    int rf69_set_pa_ramp(struct spi_device *spi, enum pa_ramp pa_ramp);
    int rf69_set_antenna_impedance(struct spi_device *spi, enum antenna_impedance antenna_impedance);
    -int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain);
    +int rf69_set_lna_gain(struct spi_device *spi, enum lna_gain lna_gain);
    int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 exponent);
    int rf69_set_bandwidth_during_afc(struct spi_device *spi, enum mantisse mantisse, u8 exponent);
    int rf69_set_ook_threshold_dec(struct spi_device *spi, enum threshold_decrement threshold_decrement);
    diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h
    index 5ac3d33a3d0c..eabaea99949d 100644
    --- a/drivers/staging/pi433/rf69_enum.h
    +++ b/drivers/staging/pi433/rf69_enum.h
    @@ -65,7 +65,7 @@ enum antenna_impedance {
    two_hundred_ohm
    };

    -enum lnaGain {
    +enum lna_gain {
    automatic,
    max,
    max_minus_6,
    --
    2.16.2
    \
     
     \ /
      Last update: 2018-03-14 21:47    [W:3.798 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site