lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [3/5] Bluetooth: btmrvl: One check less in btmrvl_sdio_card_to_host()
From
Date
>> @@ -797,12 +792,18 @@ static int btmrvl_sdio_card_to_host(struct btmrvl_private *priv)
>> break;
>> }
>>
>> -exit:
>> - if (ret) {
>> - hdev->stat.err_rx++;
>> - kfree_skb(skb);
>> - }
>> + return 0;
>> +
>> +free_skb:
>> + kfree_skb(skb);
>> +e_io:
>> + ret = -EIO;
>> + goto increment_counter;
>>
>> +e_inval:
>> + ret = -EINVAL;
>> +increment_counter:
>> + hdev->stat.err_rx++;
>> return ret;
>
> Nope!
>
> This is not easier to read for me. This goto exit jumping and I hate that.

Can the software design direction become feasible to omit the repeated check
for the variable “ret” (and further initialisations)?

Regards,
Markus

\
 
 \ /
  Last update: 2018-03-13 08:47    [W:0.054 / U:18.988 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site