lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 27/31] perf top: Fix top.call-graph config option reading
    Date
    From: Yisheng Xie <xieyisheng1@huawei.com>

    When trying to add the "call-graph" variable for top into the
    .perfconfig file, like:

    [top]
    call-graph = fp

    I that perf_top_config() do not parse this variable.

    Fix it by calling perf_default_config() when the top.call-graph variable
    is set.

    Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Fixes: b8cbb349061e ("perf config: Bring perf_default_config to the very beginning at main()")
    Link: http://lkml.kernel.org/r/1520853957-36106-1-git-send-email-xieyisheng1@huawei.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-top.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
    index 0a26b56afcc5..113c298ed38b 100644
    --- a/tools/perf/builtin-top.c
    +++ b/tools/perf/builtin-top.c
    @@ -1223,8 +1223,10 @@ parse_callchain_opt(const struct option *opt, const char *arg, int unset)

    static int perf_top_config(const char *var, const char *value, void *cb __maybe_unused)
    {
    - if (!strcmp(var, "top.call-graph"))
    - var = "call-graph.record-mode"; /* fall-through */
    + if (!strcmp(var, "top.call-graph")) {
    + var = "call-graph.record-mode";
    + return perf_default_config(var, value, cb);
    + }
    if (!strcmp(var, "top.children")) {
    symbol_conf.cumulate_callchain = perf_config_bool(var, value);
    return 0;
    --
    2.14.3
    \
     
     \ /
      Last update: 2018-03-13 13:09    [W:4.658 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site