lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux-next: build warning after merge of the net-next tree
From
Date
Hi Stephen,

On 03/13/2018 01:11 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (sparc
> defconfig) produced this warning:
>
> net/core/pktgen.c: In function 'pktgen_if_write':
> net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> }
> ^
>
> Introduced by commit
>
> 35951393bbff ("pktgen: Remove VLA usage")
>

Thanks for the report.

David:

If this code is not going to be executed very often [1], then I think it
is safe to use dynamic memory allocation instead, as this is not going
to impact the performance.

What do you think?

[1] https://lkml.org/lkml/2018/3/9/630

Thanks
--
Gustavo


\
 
 \ /
  Last update: 2018-03-13 12:46    [W:0.045 / U:4.844 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site