lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
On Tue, 13 Mar 2018 10:58:16 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote:
> >
> > Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>
> >
> > On Mon, 12 Mar 2018 15:09:03 +0530
> > <hariprasath.elango@gmail.com> wrote:
> >
> > > From: HariPrasath Elango <hariprasath.elango@gmail.com>
> > >
> >
> > Please avoid use of 'From' tag specially when there is only one
> > 'Signed-off-by' tag and its same.
>
> But the email client isn't putting the correct info in the email header,
> so this line is needed.
>
> And if it's redundant, not a problem, git handles it just fine, better
> to be safe.


Thanks Greg, for giving the information.
In that case, we can keep the 'From:' tag to be on safe side.


Regards,
Ajay

\
 
 \ /
  Last update: 2018-03-13 12:06    [W:0.031 / U:1.552 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site