lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: comedi: adl_pci6208: remove redundant initialization of 'val'
From
Date
On 12/03/18 23:36, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable 'val' is initialized with a value that is never read, it is
> updated with a new value again after intitialization. Remove the
> redundant initialization and move the declaration and assignment into
> the scope of the for-loop.
>
> Cleans up clang warning:
> drivers/staging/comedi/drivers/adl_pci6208.c:61:15: warning: Value
> stored to 'val' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/comedi/drivers/adl_pci6208.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/adl_pci6208.c b/drivers/staging/comedi/drivers/adl_pci6208.c
> index d39b4eabce8d..e21840e9002d 100644
> --- a/drivers/staging/comedi/drivers/adl_pci6208.c
> +++ b/drivers/staging/comedi/drivers/adl_pci6208.c
> @@ -58,12 +58,11 @@ static int pci6208_ao_insn_write(struct comedi_device *dev,
> unsigned int *data)
> {
> unsigned int chan = CR_CHAN(insn->chanspec);
> - unsigned int val = s->readback[chan];
> int ret;
> int i;
>
> for (i = 0; i < insn->n; i++) {
> - val = data[i];
> + unsigned int val = data[i];
>
> /* D/A transfer rate is 2.2us */
> ret = comedi_timeout(dev, s, insn, pci6208_ao_eoc, 0);
>

Looks good, thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-

\
 
 \ /
  Last update: 2018-03-13 11:43    [W:0.029 / U:5.576 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site