lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 2/2] zram: drop max_zpage_size and use zs_huge_class_size()
Hello Minchan,

On (03/13/18 18:02), Minchan Kim wrote:
> Sorry for being late.
> I love this patchset! Just a minor below.

:)

[..]
> > + if (!huge_class_size)
> > + huge_class_size = zs_huge_class_size();
>
> If it is static, we can do this in zram_init? I believe it's more readable in that
> it's never changed betweens zram instances.

We need to have at least one pool, because pool decides where the
watermark is. At zram_init() stage we don't have a pool yet. We
zs_create_pool() in zram_meta_alloc() so that's why I put
zs_huge_class_size() there. I'm not in love with it, but that's
the only place where we can have it.

-ss

\
 
 \ /
  Last update: 2018-03-13 11:25    [W:0.069 / U:37.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site