lkml.org 
[lkml]   [2018]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND v5] perf/core: Fix installing arbitrary cgroup event into cpu

* linxiulei@gmail.com <linxiulei@gmail.com> wrote:

> /*
> * Because cgroup events are always per-cpu events,
> * this will always be called from the right CPU.
> */

> + /*
> + * if only the cgroup is running on this cpu
> + * and cpuctx->cgrp == NULL (otherwise it would've
> + * been set with running cgroup), we put this cgroup
> + * into cpu context. Or it would case mismatch in
> + * following cgroup events at event_filter_match()
> + */

Beyond making sure that what you comment on makes sense, please also follow
existing comment style, which I quoted above.

There's 3 separate mistakes in that paragraph alone.

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-03-12 08:53    [W:0.071 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site